[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19992 - trunk/subversion/svnserve

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-06-13 15:12:24 CEST

On 6/13/06, Madan U Sreenivasan <madan@collab.net> wrote:

> Do you think such a long comment is required here? The reason is anyways
> explained in the log...Also I think this will confuse the reader, as to
> why such a long comment was deemed necessary.
>
> Not a big deal... just my two cents worth :)

The long comment is there because it's incredibly weird and
nonintuitive that we should have to destroy that pool in order for
things to work, and incredibly weird things should be documented in
the code, not just in a commit log.

Of course, Branko is working on a fix to make that pool destruction
entirely unnecessary, but if it was going to live on in the code the
comment would be appropriate ;-)

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 13 15:13:00 2006

This is an archived mail posted to the Subversion Dev mailing list.