[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add a new method, Svn::Core::LogChangedPath#copied? for the SWIG/Ruby bindings.

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-06-13 15:47:04 CEST

Hi,

In <20060613.223305.41650850.nori1@dolphin.c.u-tokyo.ac.jp>
  "Re: [PATCH] Add a new method, Svn::Core::LogChangedPath#copied? for the SWIG/Ruby bindings." on Tue, 13 Jun 2006 22:33:05 +0900 (JST),
  Kobayashi Noritada <nori1@dolphin.c.u-tokyo.ac.jp> wrote:

> > > > > Here is a patch to add a new method, Svn::Core::LogChangedPath#copied?
> > > > > implemented with Svn::Util.copy?.
> > > >
> > > > +1
> > > > I'm very happy if you add a test case for your patch.
> > > > Anyway, please commit, nori.
> > >
> > > Here attached a new patch with a test case.
> >
> > I found some codings I don't like in your test case. What
> > about the following my idea?
>
> Great!!
> Thank you very much for simplifying my code.
> Actually I thought that stuff was ugly and I wanted to do exactly what you've
> done, but I had no idea to do it immediately...
>
> Shall I commit this one with my original patch for
> Svn::Core::LogChangedPath#copied? ?

Yes, please commit.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 13 15:47:50 2006

This is an archived mail posted to the Subversion Dev mailing list.