[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Ruby bindings' Svn::Core::Dirent#time returns Time instead of Bignum

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-06-11 18:33:33 CEST

Hi,

In <20060610.145627.07643771.nori1@dolphin.c.u-tokyo.ac.jp>
  "[PATCH] Ruby bindings' Svn::Core::Dirent#time returns Time instead of Bignum" on Sat, 10 Jun 2006 14:56:27 +0900 (JST),
  Kobayashi Noritada <nori1@dolphin.c.u-tokyo.ac.jp> wrote:

> Currently in the SWIG/Ruby bindings, Svn::Core::Dirent#time returns
> Bignum, which needs conversion when used as Time. This patch makes
> it directly return an Time instance, which I think is better.

Yes, you're right. Could you please commit, nori?

> [[[
> * subversion/bindings/swig/ruby/svn/core.rb
> (Svn::Core::Dirent#time): Return Time instead of Bignum.
> ]]]
>
>
> Index: subversion/bindings/swig/ruby/svn/core.rb
> ===================================================================
> --- subversion/bindings/swig/ruby/svn/core.rb (revision 20034)
> +++ subversion/bindings/swig/ruby/svn/core.rb (working copy)
> @@ -335,6 +335,12 @@
> def unknown?
> kind == NODE_UNKNOWN
> end
> +
> + alias _time time
> + def time
> + __time = _time
> + __time && Time.from_apr_time(__time)
> + end
> end
>
> Config = SWIG::TYPE_p_svn_config_t
>

Regards,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 11 18:34:05 2006

This is an archived mail posted to the Subversion Dev mailing list.