Re: [PATCH] Ruby bindings' Svn::Core::Dirent#time returns Time instead of Bignum

From: Kobayashi Noritada <nori1_at_dolphin.c.u-tokyo.ac.jp>
Date: 2006-06-12 05:32:15 CEST

Hi,

> > Currently in the SWIG/Ruby bindings, Svn::Core::Dirent#time returns
> > Bignum, which needs conversion when used as Time. This patch makes
> > it directly return an Time instance, which I think is better.
>
> Yes, you're right. Could you please commit, nori?

Thank you for reviewing my patch. I committed at r20042 and nominated
to the 1.4.x release branch at r20043.
When committing, I improved my log message a little since I think the
returned value is an Integer, not fixed to either a Bignum or a Fixnum.
Is it right?

Thanks,

-nori

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 12 05:32:42 2006

This message: [ Message body ]
Next message: Kobayashi Noritada: "[PATCH] Add a new method, Svn::Core::LogChangedPath#copied? for the SWIG/Ruby bindings."
Previous message: Jelmer Vernooij: "Re: [PATCH] Fill in callbacks for svn_ra_callbacks2_t()"
In reply to: Kouhei Sutou: "Re: [PATCH] Ruby bindings' Svn::Core::Dirent#time returns Time instead of Bignum"

Contemporary messages sorted: [ By Date ] [ By Thread ] [ By Subject ] [ By Author ] [ By messages with attachments ]