On 6/3/06, Branko Èibej <brane@xbc.nu> wrote:
> D.J. Heap wrote:
> > Any objections to the attached patch? Its a step toward supporting
> > Apache 2.2/APR 1.x on Win32.
> [First of all, I must apologise to you for dropping the ball on solving
> this problem. What follows is not intended as a criticism of your patch,
> but a discussion of the perms-modifying code in general.]
No problem.
[snip]
>
> Now here's my proposal for remedying this situation:
>
> 1. Create a *private*, Unix-specific function in libsvn_subr that does
> the jumping-through-hoops that svn_io_set_file_executable and
> svn_io_set_file_read_write_carefully do now.
>
> 2. Reimplement svn_io_set_file_executable, svn_io_set_file_read_write
> and svn_io_set_file_read_only so that, on Unix, they call this new
> hoop-jumping function. On Windows, they should either do nothing (as
> ...set_file_executable does now) or call apr_file_attrs_set.
>
> 3. Deprecate svn_io_set_file_read_write_carefully and reimplement it as
> a wrapper for svn_io_set_file_read_(write|only).
>
Ok, I'll try to rework it to that end.
Thanks!
DJ
Received on Sun Jun 4 01:22:19 2006