[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Replace svn_io_set_file_read_write_carefully

From: D.J. Heap <djheap_at_gmail.com>
Date: 2006-06-04 06:37:34 CEST

Something like this? It passes ra_local tests on Win32 and FC5.

Log:
Deprecate svn_io_set_file_read_write_carefully and update
the svn_io_set_file_read* functions to handle permissions on
unix or just set the appropriate attributes on Windows.

See these email threads for previous discussion:
http://svn.haxx.se/dev/archive-2006-02/0747.shtml
http://svn.haxx.se/dev/archive-2006-06/0093.shtml

* subversion/include/svn_io.h
 Deprecate svn_io_set_file_read_write_carefully.

* subversion/libsvn_wc/props.c
 (svn_wc_prop_set2): Use appropriate svn_io_set_file_read_* function
  rather than svn_io_set_file_read_write_carefully..

* subversion/libsvn_wc/log.c
 (install_committed_file): Ditto.

* subversion/libsvn_wc/adm_ops.c
 (svn_wc_add_lock, svn_wc_remove_lock): Ditto.

* subversion/libsvn_wc/translate.c
 (svn_wc__maybe_set_read_only): Ditto.

* subversion/libsvn_subr/io.c
  (io_set_file_perms): New function to help deal with file permissions
  on unix.
  (svn_io_set_file_read_write_carefully): Just forward call to appropriate
  svn_io_set_file_read* functions.
  (svn_io_set_file_read_only): Call io_set_file_perms helper on unix but
  just set the appropriate attributes on Windows.
  (svn_io_set_file_read_write): Ditto.
  (svn_io_set_file_executable): Call io_set_file_perms helper on unix but
  just return on Windows.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Jun 4 06:38:11 2006

This is an archived mail posted to the Subversion Dev mailing list.