On 6/3/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
> On 5/31/06, David James <djames@collab.net> wrote:
> > Nice patch, Vlad! I have a few suggestions on how we can improve this patch:
> > - If the user does not supply a --with-sasl option, we should look
> > in the standard locations for the SASL library (e.g. /usr,
> > /usr/local). If SASL is found, we should use it.
> > - If the user supplies a --with-sasl option, but does not specify a
> > directory, we should look in the standard locations (e.g. /usr,
> > /usr/local).
> > - If the user supplies a --with-sasl option, and SASL is not found,
> > configure should abort with an error message.
> > [...]
> I attached a revised version of the M4 file. Let me know what you think.
Looks good! I've committed your patch to svn trunk in r19923. I made a
few tweaks to the log message before committing (see below).
[[[
Update the Unix build system to link Cyrus SASL into svnserve, if
Cyrus SASL is available.
NOTE: We don't actually use the Cyrus SASL library yet, but we are
planning to do so.
Patch by: Vlad Georgescu <vgeorgescu@gmail.com>
Review by: me
* build/ac-macros/sasl.m4: New file.
* configure.in: Call SVN_LIB_SASL.
* Makefile.in
(SVN_SASL_LIBS): New AC_SUBSTed variables.
(INCLUDES): Add SVN_SASL_INCLUDES.
* aclocal.m4
Add build/ac-macros/sasl.m4 to the list of supplementary macros.
* build.conf
(sasl): New entry.
(libsvn_ra_svn, svnserve): Add sasl to the list of dependencies.
]]]
> I'd also like some feedback on the following idea:
> I'm thinking of extracting the authentication-related functions from
> libsvn_ra_svn/client.c, putting them in another file, and then
> creating a new file with the same interface that does authentication
> through SASL. I would then conditionally compile & link only one of
> those files depending on whether or not SASL is present on the system.
> Does something like this make sense?
That sounds reasonable to me, but I'm not particularly familiar with
svnserve at this point. Could you post your svnserve questions in a
separate thread so that they get more attention?
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 4 04:17:26 2006