Daniel Rall wrote:
>>Only thing that seems wrong in this list is 'switch' -- can we not use the
>>peg-rev syntax with 'svn switch'? If not, that's a(n admittedly minor)
>>shortcoming.
>
> Yeah, I debated on that one (which also applies to 'switch
> --relocate'). Neither prototype from svn_client.h includes a peg rev
> parameter:
>
> svn_error_t *
> svn_client_switch(svn_revnum_t *result_rev,
> const char *path,
> const char *url,
> const svn_opt_revision_t *revision,
> svn_boolean_t recurse,
> svn_client_ctx_t *ctx,
> apr_pool_t *pool);
>
> svn_error_t *
> svn_client_relocate(const char *dir,
> const char *from,
> const char *to,
> svn_boolean_t recurse,
> svn_client_ctx_t *ctx,
> apr_pool_t *pool);
>
>
> While a peg rev for the PATH parameter seems fairly redundant with
> RESULT_REV, perhaps I should provide it for the sake of UI
> consistency? Looks like this would involve rev'ing the
> svn_client_switch() API.
RESULT_REV tells the revision number that you were switched to, and is not
the same as a peg revision. (It's more closely related to the REVISION
argument, which can represent a revision number or revision keyword.)
> And how about svn_client_relocate()?
Relocate doesn't even have an operative revision, so I think it doesn't need
to have a peg revision either. It's really just about rewriting working
copy URLs, and the whole point is that you *shouldn't* be using it to
traverse Time (only Space).
--
C. Michael Pilato <cmpilato@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on Tue May 9 19:30:05 2006