[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Some peg rev help text missing from command-line client

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-05-09 19:06:02 CEST

On Tue, 09 May 2006, C. Michael Pilato wrote:

> Giovanni Bajo wrote:
> > Daniel Rall wrote:
> >
> >
> >>* Mentions peg revs:
> >> blame, cat, checkout, diff, export, list, merge
> >>* Does not apply:
> >> add, cleanup, commit, delete, help, import, lock, mkdir, move,
> >> [propdel, propedit, propget, proplist, propset] (even
> >> non-revprops?), resolved, revert, status, switch, unlock, update
> >>* Does not mention, but needs to now/future:
> >> copy, info, log
> >>
> >>Does this look like the appropriate set of commands which need peg rev
> >>help text added for them?
> >
> >
> > FWIW, it's fine by me!
>
> Only thing that seems wrong in this list is 'switch' -- can we not use the
> peg-rev syntax with 'svn switch'? If not, that's a(n admittedly minor)
> shortcoming.

Yeah, I debated on that one (which also applies to 'switch
--relocate'). Neither prototype from svn_client.h includes a peg rev
parameter:

svn_error_t *
svn_client_switch(svn_revnum_t *result_rev,
                  const char *path,
                  const char *url,
                  const svn_opt_revision_t *revision,
                  svn_boolean_t recurse,
                  svn_client_ctx_t *ctx,
                  apr_pool_t *pool);

svn_error_t *
svn_client_relocate(const char *dir,
                    const char *from,
                    const char *to,
                    svn_boolean_t recurse,
                    svn_client_ctx_t *ctx,
                    apr_pool_t *pool);

While a peg rev for the PATH parameter seems fairly redundant with
RESULT_REV, perhaps I should provide it for the sake of UI
consistency? Looks like this would involve rev'ing the
svn_client_switch() API.

And how about svn_client_relocate()?

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Tue May 9 19:06:58 2006

This is an archived mail posted to the Subversion Dev mailing list.