[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Some peg rev help text missing from command-line client

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-05-09 19:26:12 CEST

On Tue, 09 May 2006, Giovanni Bajo wrote:

> Daniel Rall wrote:
>
> >* Mentions peg revs:
> > blame, cat, checkout, diff, export, list, merge
> >* Does not apply:
> > add, cleanup, commit, delete, help, import, lock, mkdir, move,
> > [propdel, propedit, propget, proplist, propset] (even
> > non-revprops?), resolved, revert, status, switch, unlock, update
> >* Does not mention, but needs to now/future:
> > copy, info, log
> >
> >Does this look like the appropriate set of commands which need peg rev
> >help text added for them?
>
> FWIW, it's fine by me!

Hrm, svn_client_copy3() doesn't take an explicit peg rev either, only
a SRC_REVISION parameter:

svn_error_t *
svn_client_copy3(svn_commit_info_t **commit_info_p,
                 const char *src_path,
                 const svn_opt_revision_t *src_revision,
                 const char *dst_path,
                 svn_client_ctx_t *ctx,
                 apr_pool_t *pool);

For 'copy', I suppose that these two (redudant) UIs for specifying
SRC_REVISION should be handled in subversion/svn/copy-cmd.c, rather
than via the API? AFAICT, specifying SRC_REVISION via a peg rev is
currently not handled there.

(This is a related discussion to the one about 'switch'.)

Here's a patch adding documentation for 'info' and 'log', which I will
propose for backport to 1.4.x after it's committed:

[[[
* subversion/svn/main.c
  (svn_cl__cmd_table): Document that 'info' and 'log' accept a peg
   rev.

Found by: giovannibajo
]]]

Index: subversion/svn/main.c
===================================================================
--- subversion/svn/main.c (revision 19580)
+++ subversion/svn/main.c (working copy)
@@ -367,10 +367,11 @@
 
   { "info", svn_cl__info, {0}, N_
     ("Display information about a local or remote item.\n"
- "usage: info [TARGET...]\n"
+ "usage: info [TARGET[@REV]...]\n"
      "\n"
      " Print information about each TARGET (default: '.')\n"
- " TARGET may be either a working-copy path or URL.\n"),
+ " TARGET may be either a working-copy path or URL. If specified, REV\n"
+ " determines in which revision the target is first looked up.\n\n"),
     {'r', 'R', svn_cl__targets_opt, svn_cl__incremental_opt, svn_cl__xml_opt,
      SVN_CL__AUTH_OPTIONS, svn_cl__config_dir_opt} },
 
@@ -411,13 +412,15 @@
   { "log", svn_cl__log, {0}, N_
     ("Show the log messages for a set of revision(s) and/or file(s).\n"
      "usage: 1. log [PATH]\n"
- " 2. log URL [PATH...]\n"
+ " 2. log URL[@REV] [PATH...]\n"
      "\n"
      " 1. Print the log messages for a local PATH (default: '.').\n"
      " The default revision range is BASE:1.\n"
      "\n"
      " 2. Print the log messages for the PATHs (default: '.') under URL.\n"
- " The default revision range is HEAD:1.\n"
+ " If specified, REV determines in which revision the URL is first\n"
+ " looked up. The default revision range is HEAD:1.\n"
+ " \n"
      "\n"
      " With -v, also print all affected paths with each log message.\n"
      " With -q, don't print the log message body itself (note that this is\n"

  • application/pgp-signature attachment: stored
Received on Tue May 9 19:35:48 2006

This is an archived mail posted to the Subversion Dev mailing list.