[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fixes for various cosmetic and documentation errors.

From: Ed Price <ed.price_at_gmail.com>
Date: 2006-03-18 18:01:51 CET

> An excellent set of fixes. Thanks. Just one or two nits.

Thanks!

> > * notes/releases.txt: Remove obsolete text. Fix test directory name.
> > Add 'make check-swig-py'. Fix whitespace.
> [...]
>
> The log message is good and I appreciate the effort you went to to give all
> this detail, though if I commit it I'll abbreviate it somewhat.

OK.

> > Index: subversion/libsvn_wc/entries.h
> > ===================================================================
> > - the entries file. Be careful when setting DO_SYNC to FALSE, if there
> > + the entries file. Be careful when setting DO_SYNC to FALSE; if there
> > is no subsequent svn_wc__entries_write call the modifications will be
> > lost when the access baton is closed.
>
> You might as well go the whole hog and use a colon to introduce the explanatory
> part.

OK. Either one is better than comma, I think :)

> > Index: subversion/libsvn_wc/adm_ops.c
> > ===================================================================
> > @@ -1308,8 +1308,8 @@
> >
> > - For files, svn_wc_remove_from_revision_control(), baby.
> >
> > - - Added directories may contain nothing but added children, and
> > - reverting the addition of a directory necessary means reverting
> > + - Added directories cannot may contain nothing but added children, and
>
> Oops! An unfinished edit?

Arg! Yes, sort of. I had reworded some of that text but then decided
it was not an obvious improvement. I tried separating obvious fixes from
other potentially more controversial "improvements"...

The only intended fix in that section is "necessarily" (instead of "necessary").

Sorry and thanks for catching that!

> > + reverting the addition of a directory necessarily means reverting
> > the addition of all the directory's children. Again,
> > svn_wc_remove_from_revision_control() should do the trick.
>
> I can adjust these for you as you wish, and then commit your patch.

Please, yes, that would be great.

Thanks again,
-Ed

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 18 18:02:05 2006

This is an archived mail posted to the Subversion Dev mailing list.