[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [RESEND] add support for svn_client_info to perl bindings

From: Geoff Richards <qef_at_ungwe.org>
Date: 2006-03-18 17:56:30 CET

On Tue, Mar 07, 2006 at 11:51:03AM -0800, Garrett Rooney wrote:
> On 3/7/06, Al Tobey <tobert@gmail.com> wrote:
>
> > You're absolutely right. Once I got it working and did the svn diff,
> > I had to move on to other stuff (which is a lame excuse) and didn't
> > fill in the error handling. I've attached a cleaned up version that
> > matches the rest of the binding code. The complete path of errors
> > through swig to perl land appears to me to be inconsisent, so I just
> > stuck with doing it just like similar functions such as
> > svn_client_blame()/svn_swig_pl_blame_func().
>
> Looks good to me, committed in r18758.
>
> Thanks!

There's a small problem with this patch. In this file:

    subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c

The new function 'svn_swig_pl_info_receiver' which this patch added
has a 'return' which doesn't specify what error value to return.
gcc complains about it. I don't know what it should actually return
though.

-- 
--- Geoff Richards -------------><-------------- http://ungwe.org/ ---
"I tried to fling my shadow at the moon,
 The while my blood leapt with a wordless song."  --  Theodore Roethke
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 18 17:56:46 2006

This is an archived mail posted to the Subversion Dev mailing list.