Re: [PATCH] Correct two doc strings and rename a local type for clarity.

On Mon, Mar 13, 2006 at 12:14:15PM +0000, Julian Foad wrote:
> Any problems with this?
>

+1, looks good, only one extra comment below. It's nice to have someone
else looking at diff, thanks Julian!

> @@ -2457,11 +2358,6 @@ do_diff_summarize_peg(const struct diff_
> Svn_client_diff3() is the single entry point for all of the diff

"svn_client_diff3()"? Even though it is as the start of the sentence.

> operations, and will be in charge of examining the inputs and

"is in charge"? Or perhaps drop everything after the comma - it doesn't
add much.

> making decisions about how to accurately report contextual diffs.
> -
> - NOTE: In the near future, svn_client_diff3() will likely only
> - continue to report textual differences in files. Property diffs
> - are important, too, and will need to be supported in some fashion
> - so that this code can be re-used for svn_client_merge().
> */
> svn_error_t *
> svn_client_diff3(const apr_array_header_t *options,

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 13 13:36:53 2006