[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Flush stdout more often

From: Stefan Haller <haller_at_ableton.com>
Date: 2006-03-07 20:19:51 CET

Justin Erenkrantz <justin@erenkrantz.com> wrote:

> For example, one of the claims was that he really wants to support
> diff. The change submitted was to the new summarize function - it
> wouldn't touch diff at all. The diff printing code is deep down
> inside our core libraries - libsvn_diff assumes that it has a stream
> (svn_diff_file_output_unified2). At the minimum, we *must* add fflush
> after every header write in diff. But, is that a valid assumption?
> For the command-line - yes. But, for ViewVC? I'm not so sure.

Thanks for being constructive; now we're getting somewhere.

My idea was to touch cmd-line client code only, no core code, so you
don't have to make any assumptions about ViewVC or others. Nothing will
change for them.

You are right about diff, I missed that. However, as far as I can see
it is not necessary to touch libsvn_diff for that; it is sufficiant to
add fflush calls to libsvn_client/diff.c. I think it makes the most
sense to flush after the output for every file, be it props only, text
changes, status only, whatever; so the appropriate fix would be to
fflush at the end of each of the six diff_callbacks. Please correct me
if you think this is wrong.

Can you (or anybody else) think of any other places besides this and the
three one-liners in my first patch?

Stefan Haller
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 7 20:20:51 2006

This is an archived mail posted to the Subversion Dev mailing list.