[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Flush stdout more often

From: <kfogel_at_collab.net>
Date: 2006-03-07 19:46:07 CET

haller@ableton.com (Stefan Haller) writes:
> Justin Erenkrantz <justin@erenkrantz.com> wrote:
> > For example, one of the claims was that he really wants to support
> > diff. The change submitted was to the new summarize function - it
> > wouldn't touch diff at all. The diff printing code is deep down
> > inside our core libraries - libsvn_diff assumes that it has a stream
> > (svn_diff_file_output_unified2). At the minimum, we *must* add fflush
> > after every header write in diff. But, is that a valid assumption?
> > For the command-line - yes. But, for ViewVC? I'm not so sure.
> Thanks for being constructive; now we're getting somewhere.

Urgk. I'm sorry to chime in with only meta-comments in this thread,
but this is important.

Statements like "thanks for being constructive; now we're getting
somewhere" imply that Justin was being non-constructive before.
That's not fair at all. He articulated his concerns clearly and
without rancor; he may have been a bit terse, but that was easily
solved by requesting more detailed explanations, which he gave.

I don't necessarily agree with Justin's technical reasoning here, but
he's conducted himself just fine in the discussion. I don't think you
can really complain about him in that respect. Let's please limit
ourselves to technical statements on technical issues, and not hint
someone was being non-constructive when they're just disagreeing. If
you're frustrated that you can't persuade Justin, the solution is to
go find other people to persuade (which you successfully did), not
expand the issue to include Justin's moral fiber :-). (I know you
probably didn't mean to, it just came out looking like that.)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 7 21:33:35 2006

This is an archived mail posted to the Subversion Dev mailing list.