[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: delta_dirs(), meet delta_dirs()

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-03-07 17:28:28 CET

Malcolm Rowe wrote:
> I wasn't suggesting dropping svn_repos_dir_delta(), merely reimplementing
> it in terms of the reporter code, which should be fairly trivial, I think.
> It's used by 'svnadmin dump' and by mod_dav_svn's switch (though that
> codepath _also_ uses the reporter code).

If you can reimplement it like that, very cool!

Note that svnadmin dump doesn't even need svn_repos_dir_delta, though.
It only uses it as a shortcut to spit out the entirety of a revision
tree, and that could be done as *much* more compact custom code. And
mod_dav_svn only uses it for the "resource walk" phase of 'svn switch',
which has been disabled in the client since ... 1.2? 1.1? I forget.
It exists for compat with older clients, though. But again, it does the
same thing that svnadmin dump does with dir_delta -- just crawls a tree.

So, +1 on reimplementing svn_repos_dir_delta() in terms of the reporter
code if you can. If you can't, we'll deprecate it and replace its only
two known uses with a new, concise function that just drives an editor
like a 'checkout' of a transaction would.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Tue Mar 7 17:34:32 2006

This is an archived mail posted to the Subversion Dev mailing list.