[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: delta_dirs(), meet delta_dirs()

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2006-03-07 21:04:26 CET

On Tue, Mar 07, 2006 at 11:28:28AM -0500, C. Michael Pilato wrote:
> If you can reimplement it like that, very cool!
>

Unfortunately I was over-optimistic (and misled by the comments), so no
reimplementations from me :-(. See the other message I just sent.

> Note that svnadmin dump doesn't even need svn_repos_dir_delta, though.
> It only uses it as a shortcut to spit out the entirety of a revision
> tree, and that could be done as *much* more compact custom code. And
> mod_dav_svn only uses it for the "resource walk" phase of 'svn switch',
> which has been disabled in the client since ... 1.2? 1.1? I forget.
> It exists for compat with older clients, though. But again, it does the
> same thing that svnadmin dump does with dir_delta -- just crawls a tree.
>

Ah, that's good to hear. I couldn't understand what the mod_dav_svn code
was doing, but if it's only for old clients, that's great! [Since that
means I can safely ignore it, essentially, localising the change to just
svn_repos_begin_report(), which is a lot easier to test.]

> So, +1 on reimplementing svn_repos_dir_delta() in terms of the reporter
> code if you can. If you can't, we'll deprecate it and replace its only
> two known uses with a new, concise function that just drives an editor
> like a 'checkout' of a transaction would.
>

The latter sounds like an excellent idea, though I'm not _entirely_
sure what the concise function you're talking about would look like
(though that's probably because I don't understand what mod_dav_svn is
doing with it).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 7 21:05:04 2006

This is an archived mail posted to the Subversion Dev mailing list.