On Monday 27 February 2006 14:50, Marcus Rueckert wrote:
> On 2006-02-27 14:24:04 +0100, Paul de Vrieze wrote:
> > I've identified an issue with the gentoo package for subversion. The
> > configure script continues hapilly when external neon support was
> > specified but not found (wrong version). I've created a small patch
> > to remedy this.
>
> That is incorrect. An user can run svn without neon happily. he can
> still use file:// or svn:// or svn+ssh://. so enforcing neon is not
> needed. i would suggest applying this patch in your ebuild and pass an
> USE flag for it. so only if the user specifies to use neon your build
> should fail. otherwise it can happily ignore neon.
The issue is not that neon should be enforced always. But that if neon is
requested in the configure script, the script should fail when neon is
not available. This allows the user to see there is an issue with his
requested configuration.
In the case of gentoo, packages are built automatically. When neon is
listed as a dependency we want it to actually end up as a dependency, or
have subversion fail when it is not available. The script currently just
continues on its merry way when neon was not found, but requested. That
makes it hard to detect when something does not go the desired way.
If the user does not explicitly request --with-neon at the configure
script command line, or specifies --without-neon, the configure script
should continue as expected and current.
Paul
--
Paul de Vrieze
Gentoo Developer
Mail: pauldv@gentoo.org
Homepage: http://www.devrieze.net
- application/pgp-signature attachment: stored
Received on Mon Feb 27 17:14:02 2006