[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch to neon library detection code.

From: Max Bowsher <maxb1_at_ukf.net>
Date: 2006-02-27 16:04:22 CET

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marcus Rueckert wrote:
> On 2006-02-27 14:24:04 +0100, Paul de Vrieze wrote:
>> I've identified an issue with the gentoo package for subversion. The
>> configure script continues hapilly when external neon support was
>> specified but not found (wrong version). I've created a small patch to
>> remedy this.
>
>
> That is incorrect. An user can run svn without neon happily. he can
> still use file:// or svn:// or svn+ssh://. so enforcing neon is not
> needed. i would suggest applying this patch in your ebuild and pass an
> USE flag for it. so only if the user specifies to use neon your build
> should fail. otherwise it can happily ignore neon.
>
> just my 2 cents

The correct behaviour is somewhere between the two suggestions above:
We should error iff --with-neon was explicitly specified, but not found.

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFEAxT1fFNSmcDyxYARAlEQAJ4m0XiYHxMc9NB5UshYEqTGfqPlCACfaKHx
WfiotBFa7QlgJbJDfLaPA6Y=
=R6/C
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 27 16:57:25 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.