Re: Circular library dependency under Windows? (was: Re: svn commit: r18462 - in trunk/subversion: libsvn_fs libsvn_fs_base libsvn_fs_fs)

On Wed, Feb 15, 2006 at 09:47:02AM -0600, kfogel@collab.net wrote:
> "Peter N. Lundblad" <peter@famlundblad.se> writes regarding r18462:
> > Hmmm, I thought such circular dependencies were not supported on
> > Windows...
>
> You mean having the lower-level library make calls into the
> higher-level library? Hmm, that's a good point. It just compiled and
> worked for me (Debian GNU/Linux), so I assumed there was no problem.
>
> Can anyone with more Windows development experience say for sure? If
> necessary, I can trivially rewrite the change. This would result in a
> bit of duplicated code (sigh), but I can put comments to help keep the
> duplicates in sync.
>

I'm not absolutely certain if circular dependencies are the reason, but my Cygwin build now fails with:

cd subversion/libsvn_fs_fs && /bin/sh /cygdrive/d/svn/svn-objdir/libtool --tag=CC --silent --mode=link gcc -g -O2 -DSVN_DEBUG -DAP_DEBUG -Wpointer-arith -Wwrite-strings -Wshadow -rpath /usr/local/lib -o libsvn_fs_fs-1.la -no-undefined dag.lo err.lo fs.lo fs_fs.lo id.lo key-gen.lo lock.lo revs-txns.lo tree.lo ../../subversion/libsvn_delta/libsvn_delta-1.la ../../subversion/libsvn_subr/libsvn_subr-1.la /usr/lib/libaprutil-0.la -lgdbm -ldb-4.2 -lexpat -liconv /usr/lib/libapr-0.la -lresolv -lcrypt -lz
Creating library file: .libs/libsvn_fs_fs-1.dll.a
.libs/tree.o: In function `copy_helper':
/cygdrive/d/svn/svn-objdir/../svn-trunk/subversion/libsvn_fs_fs/tree.c:1935: undefined reference to `_svn_fs__same_p'
/cygdrive/d/svn/svn-objdir/../svn-trunk/subversion/libsvn_fs_fs/tree.c:1937: undefined reference to `_svn_fs_path'
/cygdrive/d/svn/svn-objdir/../svn-trunk/subversion/libsvn_fs_fs/tree.c:1937: undefined reference to `_svn_fs_path'
collect2: ld returned 1 exit status
make: *** [subversion/libsvn_fs_fs/libsvn_fs_fs-1.la] Error 1

(Hmm, the immediate problem may just be that libsvn_fs isn't listed as
a library for libsvn_fs_fs. I've re-run autogen, it's not that.)

I do notice th following section in configure that implies that Cygwin
is the only platform that can't do circular linkage.

AC_MSG_CHECKING([whether to avoid circular linkage at all costs])
case $host in
  *-*-cygwin*)
    AC_MSG_RESULT([yes])
    AC_DEFINE([SVN_AVOID_CIRCULAR_LINKAGE_AT_ALL_COSTS_HACK], 1,
              [Define if circular linkage is not possible on this platform.])
    ;;
  *)
    AC_MSG_RESULT([no])
    ;;
esac

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 16 12:50:42 2006