Circular library dependency under Windows? (was: Re: svn commit: r18462 - in trunk/subversion: libsvn_fs libsvn_fs_base libsvn_fs_fs)

"Peter N. Lundblad" <peter@famlundblad.se> writes regarding r18462:
> > Log:
> > Fix issue #2398: bogus pointer comparison led to server-side
> > assert failure.
> >
> > * subversion/libsvn_fs/fs-loader.h, subversion/libsvn_fs/fs-loader.c
> > (svn_fs__same_p): New function.
> >
> > * subversion/libsvn_fs_fs/tree.c
> > (copy_helper): Use above to check equality of the two filesystems,
> > instead of depending on pointer equality. Handle inequality by
> > returning an error, instead of failing an assertion.
> >
> > * subversion/libsvn_fs_base/tree.c
> > (copy_helper): Same.
>
> Hmmm, I thought such circular dependencies were not supported on
> Windows...

You mean having the lower-level library make calls into the
higher-level library? Hmm, that's a good point. It just compiled and
worked for me (Debian GNU/Linux), so I assumed there was no problem.

Can anyone with more Windows development experience say for sure? If
necessary, I can trivially rewrite the change. This would result in a
bit of duplicated code (sigh), but I can put comments to help keep the
duplicates in sync.

Thanks for the review, Peter.

-Karl

-- 
www.collab.net  <>  CollabNet  |  Distributed Development On Demand
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org