kfogel@collab.net wrote:
> Greg Stein <gstein@lyra.org> writes:
>> Part of the dev-process with the no-space model is being able to
>> search for "dir(" so that you can find calls to the svn_fs_make_dir
>> function without picking up "dir" in random places. And without having
>> to type the full svn_fs_make_dir. Yup, a user strategy, but an
>> incredibly effective/efficient one.
>
> Hmm, I hadn't thought of that.
>
> We haven't been observing this convention in our code very much.
> Function calls will put the paren on the same line as the function's
> name when the first parameter also fits on that line, but when the
> first parameter is on the next line, we usually (but not always) put
> the paren on the next line too. Now that you mention it, the most
> consistent exception to that is code written by you... I always
> wondered what was up with, e.g., this from libsvn_ra_dav/session.c:
>
> authorities = svn_config_get_server_setting(
> cfg, server_group,
> SVN_CONFIG_OPTION_SSL_AUTHORITY_FILES,
> NULL);
>
> Now I know :-). Nice tactic. (It happens even more often in
> declarations, where it's less useful I guess, but whatever.)
>
> Anyway, one of the effects of r18471 was to undo a lot of those cases.
> Not all of them -- it turns out I missed 28, due to silly reasons not
> worth going into here. Now, I could put back the old cases, but
> they'd still be a minority and we'd be inconsistent. Or I could apply
> the patch below which "fixes" (or breaks, depending on how you look at
> it) the 28 remaining instances. I was about to test & commit this
> when I read your mail and decided to hold off.
>
> Thoughts? Greg? Anyone? Bueller?
My vote as to the style was based on the concept that the "(" was part of
the function token (not really, but syntactically) So, I would claim that
if the opening "(" is on the next line you break that rule and thus if you
are looking for "function(" you will miss those cases.
Any others from the "no-space" voting block? (I know what the "space" voting
block would say :-)
--
Michael Sinz Technology and Engineering Director/Consultant
"Starting Startups" mailto:michael.sinz@sinz.org
My place on the web http://www.sinz.org/Michael.Sinz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 16 11:59:41 2006