Re: [PATCH] Adjust more_finfo() on Win32 to behave more like its Unix/Linux counterpart

I'm looking at svn_io_set_file_read_write_carefully, and try as I might,
I can't imagine what this monstrosity is doing in our public API. We
must all have been smoking something really weird to allow it in in the
first place.

It is APR's job to do the right platform-specific thing. The semantics
that this function is trying to implement should have gone into APR's
Unix-specific implementation of apr_file_attrs_set.

I propose we deprecate this function immediately and change the
implementation to just call svn_io_set_file_read_only or
svn_io_set_file_read_write, then concentrate on getting the correct
behaviour implemented in APR.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 11 19:51:04 2006