Branko Čibej wrote:
> I'm looking at svn_io_set_file_read_write_carefully, and try as I might,
> I can't imagine what this monstrosity is doing in our public API. We
> must all have been smoking something really weird to allow it in in the
> first place.
>
> It is APR's job to do the right platform-specific thing. The semantics
> that this function is trying to implement should have gone into APR's
> Unix-specific implementation of apr_file_attrs_set.
>
> I propose we deprecate this function immediately and change the
> implementation to just call svn_io_set_file_read_only or
> svn_io_set_file_read_write, then concentrate on getting the correct
> behaviour implemented in APR.
+1 on deprecating it. It's name and doc string don't make a lot of sense. It
starts with "Minimally change ..." and then contradicts that with things like
"as much as the OS allows". And "If enable_write is false, make the file
write-only." Is that just a typo for "read-only"?
I don't think just calling one of the existing functions will do, but I'm sure
we can come up with some better solution or at least a better name and doc-string.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 13 20:18:07 2006