Branko Čibej wrote:
> I'm looking at svn_io_set_file_read_write_carefully, and try as I might,
> I can't imagine what this monstrosity is doing in our public API. We
> must all have been smoking something really weird to allow it in in the
> first place.
>
> It is APR's job to do the right platform-specific thing. The semantics
> that this function is trying to implement should have gone into APR's
> Unix-specific implementation of apr_file_attrs_set.
>
> I propose we deprecate this function immediately and change the
> implementation to just call svn_io_set_file_read_only or
> svn_io_set_file_read_write, then concentrate on getting the correct
> behaviour implemented in APR.
>
> -- Brane
Sounds wise. Know if there is any reason there isn't a apr_file_attrs_get()?
Lastly, I found out that another "strange" usage of apr_stat (in
svn_io_file_rename) was removed in r17366 on trunk. So with that, all
the odd performance measures I saw in 1.30 is gone.
/Andreas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 11 20:59:48 2006