[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_repos_get_logs3 and unbounded memory use

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-02-09 19:52:17 CET

Garrett Rooney wrote:
> On 2/9/06, Julian Foad <julianfoad@btopenworld.com> wrote:
>
>>Sorry to jump in with what may be just an ignorant question, but could you
>>briefly explain whether such a large number of paths is passed in common
>>every-day scenarios (and, if so, why) or just in some extreme use cases like
>>"svn log */*/*.c".
>
> I was able to reproduce it via 'svn log URL --targets FILE', where
> FILE contains a list of paths within URL. I have no idea what's
> actually causing this in practice, but I have seen numerous crashes
> that were caused by this on svn.apache.org, so something's doing it.
> So if I had to guess, I'd say it's an extreme edge case, but it does
> actually occur.

OK, thanks.

> Regardless of how easy it is to reproduce this problem with the
> command line tools, the fact that it can happen at all via the
> protocol/API requires that we fix it.

Right. Fully agreed that we should fix this here, but I also wonder if there's
an inefficient caller that we should be looking for, where we might make even
bigger gains by avoiding this scenario. Maybe there isn't, but ...

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 9 19:54:17 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.