Garrett Rooney wrote:
> So, just to see what the impact would be like, I implemented this the
> "easy" way, not keeping any history objects open at all, just doing
> the open/prev/prev thing each time we need to move back. On my test
> case (which runs log on about 1200 paths in a repository that's got
> 867 revisions in it) this results in about a 20% speed hit, with max
> memory usage (via the oh-so-scientific "look at the output of top"
> method of measuring) capping out at around 3 megs, as opposed to about
> 250 megs the old way of doing things.
As I noted on the phone a few minutes ago, my opinion runs thusly: if
typical real-world use-cases (say, < 10 paths passed to 'svn log') don't
suffer noticably from this approach, then the fix is fine with me -- it
solves memory problems for all use-cases, even if the obnoxious cases
suffer a 20% hit in speed. At least the operations (eventually)
complete successfully.
--
C. Michael Pilato <cmpilato@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on Thu Feb 9 18:42:04 2006