Re: svn commit: r18363

On Wed, Feb 08, 2006 at 03:45:39PM -0500, Daniel Berlin wrote:
> > I think that we should check for a supported version, and I'm happy
> > to revert the changes to read_window_header() and add the check to
> > write_handler(), if you agree that that's okay.
>
> Sure.
>

Ok. Reverted in r18398, added the check in r18399. I also noticed that
the code you had for setting db->version depended upon us receiving the
SVNx header in one piece, whereas the existing code allowed us to receive
it incrementally. Since the version number is the last thing in the
header, it was easy enough to extend the existing incrementally-checking
code to cope with both types of header.

> BTW, thanks for doing all this

No problem: I've got a little spare time this week. (and I probably
should have reviewed the branch back when you posted the 'ready to merge'
notice: it would have avoided all the followup noise).

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 9 17:49:21 2006