Re: [PATCH] Fix corner case bug in libsvn_diff

On Wed, Feb 08, 2006 at 11:00:59PM +0100, Peter N. Lundblad wrote:
> This code isn't entirely straight. We *have* to handle 0 byte files. NOte
> that the baton fields are not uninitialized; they are set to zero in the
> svn_diff_file_diff{,34} functions.
>
> This code have served us well for years, but honestly it could need some
> more documentation in some places.
>

Yup, and I'm obviously missing something about the way it's working too
(also, I wasn't able to reproduce the original problem either, so I'm
doubly confused).

Never mind though - if it works now, there's little point in fiddling
with it. There are enough things that are actually broken without
needing to find others that could merely be polished!

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 9 17:47:19 2006