[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18363

From: Daniel Berlin <dberlin_at_dberlin.org>
Date: 2006-02-08 21:45:39 CET

> >
> > The version argument was originally there so we could issue an error if
> > the version number was higher than we knew how to handle. I later
> > removed the code to do that, and forgot to remove the argument.
> >
> > If we want that error, i'm happy to readd it, if not, we should
> > certainly remove the argument (which should be int svndiff_version
> > anyway).
> >
>
> Uh, wouldn't the right place to do that be in write_handler(), just
> after we read the SVNx header? (and which is where we would previously
> have raised the error).

That is one possible place, yes :)

>
> I think that we should check for a supported version, and I'm happy
> to revert the changes to read_window_header() and add the check to
> write_handler(), if you agree that that's okay.

Sure.

BTW, thanks for doing all this
>
> Regards,
> Malcolm
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 8 21:45:56 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.