Malcolm Rowe wrote:
>
> But I'm of the opinion that the current behaviour is a shortcoming in
> the peg-rev support for blame, so I'd like to commit this as a bugfix.
+1, because we should have consistency between commands in the absence of a
good reason not to.
> [[[
> Change the behaviour of 'svn blame' so that the default operative revision
> range will be taken from the target's peg revision (if one is provided).
> The behaviour is unchanged if no peg revision was provided, or if an
> explicit revision range was provided.
Please say here why you're changing it, i.e. "for consistency with most of the
other commands."
(Ideally, it would be "to comply with our user interface general
specifications", but we haven't written them down. :-( )
>
> * subversion/svn/blame-cmd.c
[...]
> Index: subversion/tests/cmdline/blame_tests.py
> ===================================================================
[...]
> + expected_output = svntest.wc.State('.', {
> + 'iota' : Item(verb='Sending'),
> + })
> + svntest.actions.run_and_verify_commit('.', expected_output,
> + None, None, None, None,
> + None, None)
The last five 'None's are optional so can be removed.
From Greg's email that you linked to:
> Operative rev defaults to peg rev:
> cat
> export
> info
> ls
> propget
> proplist
>
> Operative rev defaults to HEAD:
> blame
> co (bug: @pegrev not trimmed off default wc pathname)
> diff (second operative rev defaults to HEAD)
>
> Does not appear to support peg revs even though it could:
> cp
> log
> switch
"log" has since moved to the first list, and this moves "blame" to the first list.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 7 22:55:09 2006