Re: [PATCH] blame: Make default revision follow peg revision

On Tue, Feb 07, 2006 at 09:54:46PM +0000, Julian Foad wrote:
> Malcolm Rowe wrote:
> >But I'm of the opinion that the current behaviour is a shortcoming in
> >the peg-rev support for blame, so I'd like to commit this as a bugfix.
>
> +1, because we should have consistency between commands in the absence of a
> good reason not to.
>

Ok, done, r18400. Thanks for the review.

> (Ideally, it would be "to comply with our user interface general
> specifications", but we haven't written them down. :-( )
>

Yup. :-( for sure.

> >+ svntest.actions.run_and_verify_commit('.', expected_output,
> >+ None, None, None, None,
> >+ None, None)
>
> The last five 'None's are optional so can be removed.
>

Ah, thanks. I had tried something like that, but I think I removed them
all by mistake (and one of them isn't optional). I'm still pretty much
at the 'beginner/cargo-cult' stage with Python.

Regards,
Malcolm

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 9 18:13:45 2006