Re: [PATCH] [Issue 1942] svn+ssh should use the port value

Branko Čibej <brane@xbc.nu> writes:
> Kamesh Jayachandran wrote:
> > Hi All,
> > I hereby attach patch for #1942.
> >
> > Ran make check/make autodavcheck found nothing alarming.
> > Ran make svnsshcheck found 16 tests failing with and without this
> > patch and hence attribute the failures to out of date work area and
> > submit this patch.
>
> You mean you didn't actually check why those tests were failing?
> That's not nice at all.

Kamesh, did you mean "attribute the failures to causes independent of
my changes"? That's very different from "out of date work area", but
it would make a lot more sense in context.

(Were the 16 failures exactly the same failures both and without your
changes? Do you know what's causing them?)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 1 13:27:37 2006