[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [Issue 1942] svn+ssh should use the port value

From: Branko Čibej <brane_at_xbc.nu>
Date: 2006-02-01 12:23:55 CET

Kamesh Jayachandran wrote:
> Hi All,
> I hereby attach patch for #1942.
> Ran make check/make autodavcheck found nothing alarming.
> Ran make svnsshcheck found 16 tests failing with and without this
> patch and hence attribute the failures to out of date work area and
> submit this patch.
You mean you didn't actually check why those tests were failing? That's
not nice at all.

> [[[
> Fix issue #1942, svn+ssh should use the port value
> Patch by: Kamesh Jayachandran <kamesh@collab.net>
> * subversion/libsvn_ra_svn/client.c
> (find_tunnel_agent) Modified to accept the apr_uri_t*
> rather than hostinfo so that we can make use of the
> port information available in apr_uri_t.
> This port is given as -p to ssh binary in case available.
> ]]]
You forgot to mention the change in the function where find_tunnel_agent
is called.

> + if (uri->port_str != NULL)
> + {
> + (*argv)[n++] = "-p";
> + (*argv)[n++] = uri->port_str;
> + }
What if the tunnel agent isn't SSH? Plink on Windows will accept a -p
options, but you can configure other kinds of tunnel agents.

Also, this changes the interface between the Subversion client and
tunnel agents. This change should be documented somewhere, probably in
the ~/.subversion/config template.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 1 12:24:35 2006

This is an archived mail posted to the Subversion Dev mailing list.