Re: svn commit: r18312 - trunk/subversion/libsvn_ra_serf

On 1/31/06, Greg Stein <gstein@lyra.org> wrote:
> > + serf_debug__closed_conn(sess->bkt_alloc);
> > + }
>
> I don't think that call makes sense. It's going to cancel some
> checking. We haven't actually closed the connection, so this shouldn't
> be called.

If you don't call that function and have define'd
SERF_DEBUG_BUCKET_USE (still the default), serf will abort on the next
read because the debug bucket tracker won't have cleared the previous
read_status.

Here's the scenario: for a socket that eventually gets EAGAIN, we will
do a second context_run after the corresponding poll. After that
poll(), serf will abort() on the new read call because it still thinks
the socket bucket's status is EAGAIN from the previous iteration.
This debug function clears that state.

I didn't write this particular debug code (guess who did); this chunk
has touches of black voodoo that keeps me away. =) -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 1 06:03:54 2006