Re: svn commit: r18312 - trunk/subversion/libsvn_ra_serf

On Tue, Jan 31, 2006 at 09:03:27PM -0800, Justin Erenkrantz wrote:
> On 1/31/06, Greg Stein <gstein@lyra.org> wrote:
> > > + serf_debug__closed_conn(sess->bkt_alloc);
> > > + }
> >
> > I don't think that call makes sense. It's going to cancel some
> > checking. We haven't actually closed the connection, so this shouldn't
> > be called.
>
> If you don't call that function and have define'd
> SERF_DEBUG_BUCKET_USE (still the default), serf will abort on the next
> read because the debug bucket tracker won't have cleared the previous
> read_status.

Ah. Alrighty. This is caused by serf_debug__entered_loop being
commented out in context.c::check_buckets_drained(). The entered_loop
function clears that read status.

>...
> I didn't write this particular debug code (guess who did); this chunk
> has touches of black voodoo that keeps me away. =) -- justin

Heh. Guess that I may have to look into this at some point soon.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org