[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: volatile/atomic issues in the new BDB cache

From: Branko Čibej <brane_at_xbc.nu>
Date: 2006-01-28 15:42:52 CET

Philip Martin wrote:
> Branko Čibej <brane@xbc.nu> writes:
>
>
>> Philip Martin wrote:
>>
>>> First issue: the new "spinlock" appears to use CAS more than
>>> necessary, I think it can be simplified to this:
>>>
>>>
>> Don't we all wish. Saith apr_atomic.h:
>>
>>> * @warning do not mix apr_atomic's with the CAS function.
>>> * on some platforms they may be implemented by different mechanisms
>>>
>
> I think we should add a similar warning to the svn__atomic macros.
>
I agree; I'll do this and the volatile thing while I'm fixing the
memory-free bug you found with valgrind.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 28 15:44:21 2006

This is an archived mail posted to the Subversion Dev mailing list.