[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18245 - trunk/subversion/libsvn_ra_serf

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-01-27 21:32:46 CET

On Thu, 26 Jan 2006, Justin Erenkrantz wrote:

> On 1/26/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> > > + const char *attr, *attr_val;
> > > + attr = attrs[0] + 6;
> >
> > Woops, this will point at garbage if the attribute name is just xmlns.
>
> I'm not yet trying to deal with bogus XML. I just want to get enough
> parsing functional so that I can make progress on the other stuff.
>
OK, maybe a todo comment oculd say so so it doesn't get missed. Also
pointing out that this isn't bogus XML at all.

> > > + /* default namespace */
> > > + ns = "";
> >
> > Do DAV prohibit declaring another default namespace or something?
>
> It needs some namespace... *shrug*
>
Huh? What do you mean? declaring a default namespace with "xmlns='url'"
means that unprefixed element names will belong to that namespace. Are
you hard-coding assumptions about namespace prefixes (or rather no
prefixes) that the server will use?

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 27 21:33:32 2006

This is an archived mail posted to the Subversion Dev mailing list.