Re: svn commit: r18245 - trunk/subversion/libsvn_ra_serf

On 1/26/06, Peter N. Lundblad <peter@famlundblad.se> wrote:
> We usually use the same name for the struct tag and the typedef.

Fixed.

> There is no documentation, but I guess the namespace field is the
> namespace identifier (i.e. DAV in DAV:blah) and the val field is the
> namespace URI. Is that correct?

Yes - I updated the fields to be more precise.

> > + XML_Parser xmlp;
> > + ns_t *ns_list;
>
> We have a wrapper for expat in svn_xml.h that gives us some error
> handling. Maybe use that (and extend it with namespace support)?

Perhaps. But, my expectation is a lot of the XML parsing code is
going to go into serf rather than stay in Subversion. I'm not sure
yet.

> > + const char *attr, *attr_val;
> > + attr = attrs[0] + 6;
>
> Woops, this will point at garbage if the attribute name is just xmlns.

I'm not yet trying to deal with bogus XML. I just want to get enough
parsing functional so that I can make progress on the other stuff.

> > + /* default namespace */
> > + ns = "";
>
> Do DAV prohibit declaring another default namespace or something?

It needs some namespace... *shrug*

> s/1/TRUE/

Fixed.

> > + }
> > +
> > + /* check for 'prop' */
> > + if (!ctx->in_prop && strcasecmp(name, "prop") == 0)
>
> No my DAV ingorance shines through:-(, but are names case-insensitive in
> DAV?

Greg says no in another post. ;-)

> To be correct, you need to pop the namespaces of this element, but you
> know that. (I also saw the comment about the state of this code in the
> log message about check-pointing).

Yah. I added a FIXME to note this.

> expat doesn't guarantee that CDATA in an element come in one chunk, so you
> need to collect the CDATA from consecutive calls.

I'll figure that out once I get a better idea where the XML parsing
code should live.

Thanks. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 27 03:20:34 2006