[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r18218 - in trunk: . subversion/libsvn_ra_serf

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2006-01-26 20:31:54 CET

On Wed, 2006-01-25 at 15:58 -0800, Greg Stein wrote:
> Personal preference *is* relevant. That was defined long ago. An
> author (not-really when starting a new file, but definitely for a
> whole library) can choose to use space-before-paren on function calls,
> or no-space. And it should be consistent. But the choice has been
> there since the SVN project started nearly six years ago.

For the record, I wish I had done ra_svn with space-before-paren. Any
benefit I've gotten from having the code match my own preferences has
been outweighed by the personal frustration of fixing up people's
patches (when they add to the code using space-before-paren) and the
vicarious frustration of watching developers have to adjust their style
when making changes across files.

One of my old-fogey-programmer learnings is that you can get used to any
code style, no matter how stupid you think it is to start with. So I
wish we'd gone for consistency over accomodation here.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 26 20:34:02 2006

This is an archived mail posted to the Subversion Dev mailing list.