Re: svn commit: r18214 - in trunk: . build/ac-macros subversion/include subversion/libsvn_ra subversion/libsvn_ra_serf

On Tue, 24 Jan 2006 jerenkrantz@tigris.org wrote:

> Author: jerenkrantz
> Date: Tue Jan 24 20:57:24 2006
> New Revision: 18214
>
> Log:
> Add in initial stubs for libsvn_ra_serf.
>
Cool!

> Url: http://svn.collab.net/viewcvs/svn/trunk/subversion/include/svn_ra.h?rev=18214&p1=trunk/subversion/include/svn_ra.h&p2=trunk/subversion/include/svn_ra.h&r1=18213&r2=18214
> ==============================================================================
> --- trunk/subversion/include/svn_ra.h (original)
> +++ trunk/subversion/include/svn_ra.h Tue Jan 24 20:57:24 2006
> @@ -1545,6 +1545,12 @@
> apr_pool_t *pool,
> apr_hash_t *hash);
>
> +/** Initialize libsvn_ra_serf.
> + *
> + * @deprecated Provided for backward compatibility with the 1.1 API. */
> +svn_error_t * svn_ra_serf_init (int abi_version,
> + apr_pool_t *pool,
> + apr_hash_t *hash);
>
I was going to complain like gstein did, but sadly we seem to have to
provide this. But do we really need to provide it in the public header?
Couldn't we just declare it inside libsvn_ra for internal us?

>
> /**
>
> +static const char *
> +ra_serf_get_description (void)
> +{
> + return _(RA_SERF_DESCRIPTION);

Use 2 space for indentation. Same in many places.

> +}
> +
Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 25 14:24:01 2006