Re: svn commit: r18214 - in trunk: . build/ac-macros subversion/include subversion/libsvn_ra subversion/libsvn_ra_serf

On Tue, Jan 24, 2006 at 08:57:27PM -0600, jerenkrantz@tigris.org wrote:
>...
> +++ trunk/subversion/include/svn_ra.h Tue Jan 24 20:57:24 2006
> @@ -1545,6 +1545,12 @@
> apr_pool_t *pool,
> apr_hash_t *hash);
>
> +/** Initialize libsvn_ra_serf.
> + *
> + * @deprecated Provided for backward compatibility with the 1.1 API. */
> +svn_error_t * svn_ra_serf_init (int abi_version,
> + apr_pool_t *pool,
> + apr_hash_t *hash);

No need for this. There are no programs built against the 1.1 API that
will be calling this function.

>...
> +++ trunk/subversion/libsvn_ra_serf/serf.c Tue Jan 24 20:57:24 2006
>...
> +static svn_error_t *
> +svn_ra_serf__open (svn_ra_session_t *session,
> + const char *repos_URL,
> + const svn_ra_callbacks2_t *callbacks,
> + void *callback_baton,
> + apr_hash_t *config,
> + apr_pool_t *pool)
> +{
> + return NULL;
> +}

I would suggest that all of these stubs to an abort(). Thus, while
you're developing, if one is called unexpectedly, then you'll see it
right away.

>...
> +static const svn_ra__vtable_t serf_vtable = {
> + ra_serf_version,
> + ra_serf_get_description,
> + ra_serf_get_schemes,
> + svn_ra_serf__open,

You could also replace these with NULL, until they're written.

>...
> +/* Compatibility wrapper for pre-1.2 subversions. Needed? */

I'm not sure how this wrapper works, but yah: it might be needed. This
would allow a 1.0 or 1.1 client to use the 1.x SVN libraries to talk
to a repository via serf.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org