Thanks for your feedback! I've attached a new patch which addresses
your concerns. See below.
On 1/20/06, Julian Foad <firstname.lastname@example.org> wrote:
> > Currently, our build system prints a warning when SWIG 1.3.26 or
> > 1.3.27 are used. The attached patch (which I haven't tested yet)
> > removes the warning.
> > AC_MSG_WARN([Detected SWIG version $SWIG_VERSION_RAW])
> > AC_MSG_WARN([This is not compatible with Subversion])
> > - AC_MSG_WARN([Subversion can use SWIG version 1.3.24 or later])
> > + AC_MSG_WARN([Subversion is only compatible with versions of SWIG])
> > + AC_MSG_WARN([between 1.3.24 and 1.3.27])
> That message is still misleading. Let's make it plain and honest. We don't
> know that Subversion isn't compatible with 1.3.28. Say something like:
> Detected SWIG version $SWIG_VERSION_RAW. Subversion requires at
> least version 1.3.24 and is known to work with versions up to 1.3.27.
Much clearer! I'll use this message instead (with a few tweaks)
> (If that's not the case, and we know it won't work with the next version of
> SWIG, then we should change this warning into a hard error.)
The SWIG folks don't make any compatibility guarantees between
versions, but it's possible that SWIG 1.3.28 will work.
> Also, you need to heed the comment just above that test that says:
> > # If you change the required swig version number, don't forget to update:
> > # subversion/bindings/swig/INSTALL
> > # subversion/bindings/swig/NOTES
> > # packages/rpm/redhat-8+/subversion.spec
> > # packages/rpm/redhat-7.x/subversion.spec
> > # packages/rpm/rhel-3/subversion.spec
> > # packages/rpm/rhel-4/subversion.spec
> It would also be good to insert comments in those places referring back to this
> m4 macro file, and remove the specific version numbers from one or more of
> those places to reduce the amount of duplication.
Good idea! I've updated subversion/bindings/swig/INSTALL, and removed
the reference to SWIG versions in "NOTES".
I don't think the subversion.spec files need to be updated this time.
Does this patch look good?
David James -- http://www.cs.toronto.edu/~james
Received on Fri Jan 20 20:38:35 2006
To unsubscribe, e-mail: email@example.com
For additional commands, e-mail: firstname.lastname@example.org