David James wrote:
>
> I added unofficial support for SWIG 1.3.27 to Subversion trunk in
> r17279 and r17280. We should probably port these fixes to Subversion
> 1.3.x.
>
> Currently, our build system prints a warning when SWIG 1.3.26 or
> 1.3.27 are used. The attached patch (which I haven't tested yet)
> removes the warning.
[...]
> Index: build/ac-macros/swig.m4
> ===================================================================
> --- build/ac-macros/swig.m4 (revision 18117)
> +++ build/ac-macros/swig.m4 (working copy)
> @@ -76,13 +76,14 @@
> # packages/rpm/rhel-4/subversion.spec
> if test -n "$SWIG_VERSION" &&
> test "$SWIG_VERSION" -ge "103024" &&
> - test "$SWIG_VERSION" -le "103025"; then
> + test "$SWIG_VERSION" -le "103027"; then
> SWIG_SUITABLE=yes
> else
> SWIG_SUITABLE=no
> AC_MSG_WARN([Detected SWIG version $SWIG_VERSION_RAW])
> AC_MSG_WARN([This is not compatible with Subversion])
> - AC_MSG_WARN([Subversion can use SWIG version 1.3.24 or later])
> + AC_MSG_WARN([Subversion is only compatible with versions of SWIG])
> + AC_MSG_WARN([between 1.3.24 and 1.3.27])
That message is still misleading. Let's make it plain and honest. We don't
know that Subversion isn't compatible with 1.3.28. Say something like:
Detected SWIG version $SWIG_VERSION_RAW. Subversion requires at
least version 1.3.24 and is know to work with versions up to 1.3.27.
(If that's not the case, and we know it won't work with the next version of
SWIG, then we should change this warning into a hard error.)
Also, you need to heed the comment just above that test that says:
> # If you change the required swig version number, don't forget to update:
> # subversion/bindings/swig/INSTALL
> # subversion/bindings/swig/NOTES
> # packages/rpm/redhat-8+/subversion.spec
> # packages/rpm/redhat-7.x/subversion.spec
> # packages/rpm/rhel-3/subversion.spec
> # packages/rpm/rhel-4/subversion.spec
It would also be good to insert comments in those places referring back to this
m4 macro file, and remove the specific version numbers from one or more of
those places to reduce the amount of duplication.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 20 14:34:15 2006