On Sat, Jan 14, 2006 at 01:52:59AM +0000, Julian Foad wrote:
> >>Thanks for the patch... it looks fine to me. It makes the help text
> >>consistent with other help text that refers to "Berkeley DB log files"
> >>(list-dblogs and list-unused-dblogs).
>
> ... but inconsistent with the other _option_ that refers to log files:
>
Hmm, you're right. I didn't see the BDB options on 'svnadmin create'.
> {"bdb-log-keep", svnadmin__bdb_log_keep, 0,
> N_("disable automatic log file removal [Berkeley DB]")},
>
> Malcolm Rowe wrote:
> >Committed as r18097, with a little tweaking
>
> > {"clean-logs", svnadmin__clean_logs, 0,
> >- N_("remove redundant log files from source repository")},
> >+ N_("remove redundant Berkeley DB log files\n"
>
> Like with bdb-log-keep, there's no need to mention "Berkeley DB" there...
>
> >+ " from source repository [Berkeley
> >DB]")},
>
> ... when it's mentioned there. But it's not doing any harm and removal
> wouldn't create enough space to fit it onto one output line.
>
Yes, I wasn't really happy with the duplication either, though it seemed
to make sense given the arguments. The other BDB options have 'bdb'
in their names though, so it's fairly obvious that they apply to BDB
repositories only, IMO.
Do you think it'd be clearer if I removed the first instance of 'Berkeley
DB' from the text? Or not worth bothering?
Thanks for the review, anyway.
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jan 18 11:46:09 2006