Re: [PATCH] improved svnadmin hotcopy help

> On Fri, Jan 13, 2006 at 10:31:19AM -0700, Michael W Thelen wrote:
>
>>Thanks for the patch... it looks fine to me. It makes the help text
>>consistent with other help text that refers to "Berkeley DB log files"
>>(list-dblogs and list-unused-dblogs).

... but inconsistent with the other _option_ that refers to log files:

     {"bdb-log-keep", svnadmin__bdb_log_keep, 0,
      N_("disable automatic log file removal [Berkeley DB]")},

Malcolm Rowe wrote:
> Committed as r18097, with a little tweaking

> {"clean-logs", svnadmin__clean_logs, 0,
> - N_("remove redundant log files from source repository")},
> + N_("remove redundant Berkeley DB log files\n"

Like with bdb-log-keep, there's no need to mention "Berkeley DB" there...

> + " from source repository [Berkeley DB]")},

... when it's mentioned there. But it's not doing any harm and removal
wouldn't create enough space to fit it onto one output line.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 14 02:53:41 2006