[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] dav_svn_get_repo_name handling of SVNParentPath

From: Molle Bestefich <molle.bestefich_at_gmail.com>
Date: 2006-01-17 18:19:36 CET

Maxime Petazzoni wrote:
> Molle Bestefich [2006-01-17 14:40:14]:
> > Maxime Petazzoni wrote:
> > > Basically, the new dav_svn_get_repo_name2() function uses the
> > > dav_svn_split_uri function to retrieve the repository name from the
> > > current requested URI if the SVNParentPath directive is used,
> > > otherwise it acts like the old dav_svn_get_repo_name.
> >
> > So if a repository uses SVNParentPath, the repository name returned
> > will be whatever the client decides it should be - it could be an IP
> > address, or (using /etc/hosts) any arbitrary name. Whilst
> > non-SVNParentPath repositories use the name of the repository folder
> > on the server.
> >
> > Seems inconsistent to me - why not just rev the function to always use
> > whatever the client provides in the URI, instead of doing different
> > things depending on a logically completely unrelated aspect of the
> > server configuration?
>
> In a non-SVNParentPath setup, the user specifies a descriptive
> repository name with the SVNReposName directive.

Well, no they don't. Ok, now I'm just being rude :-)...
But I don't at least, for any of the 10 repositories that I administer.

> But in a SVNParentPath based setup, the user can't specify a name per
> repository with SVNReposName, and dav_svn_get_repo_name returns NULL
> (there is no repository name defined).

Since we've never heard anyone complain about the lack of
SVNReposName, perhaps a good bet would be that the feature is pretty
useless and should just be removed? The repository name would then
always be 1:1 with the name of the folder that contains it.

If the SVNReposName property is actually useful for anything, it is at
least obviously misplaced in the Apache config file. It should
instead live in a per-repository config file where it would be
insensitive to issues such as whether repositories are enumerated with
SVNPath or SVNParentPath.

> This patch adds a new version of the dav_svn_get_repo_name function
> which returns the repository directory name in a SVNParentPath based
> setup, and the SVNReposName directive value in a non-SVNParentPath
> setup. That's all.

I appreciate that you're working on fixing stuff. I'm just wondering
why all the complexity, why not just say let's do things this way and
*always* pick the name out of the URI...

> I don't really get why you are talking about IP addresses, host names
> and stuff, maybe you could explain ?

Obviously only the host name part of the URI is modifiable. Forget
about it, it was a dumb comment. Didn't think straight :-).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 17 21:14:56 2006

This is an archived mail posted to the Subversion Dev mailing list.