[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix 2441: 'svnadmin load' malformed dumpfile errors are intolerably vague

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2006-01-17 06:50:12 CET

Thanks Julian.

With regards
Kamesh Jayachandran
Julian Foad wrote:
> Kamesh Jayachandran wrote:
>> Hi Julian,
>> Thanks for your feedback.
>> Attaching the new patch.
> [...]
>> [[[
>> Fix issue #2441, 'svnadmin load' malformed dumpfile errors are
>> intolerably vague
>>
>> * subversion/libsvn_repos/load.c
>> (read_header_block): Error message with a hint.
>> ]]]
>
> OK, thanks, I've committed this patch, or something very close to it,
> because it does improve the situation. I have said in the log message
> that it is "part of" issue #2441.
>
> - Julian
>
>
>> if (header_str->data[i] == '\0')
>> - return svn_error_create (SVN_ERR_STREAM_MALFORMED_DATA, NULL,
>> - _("Found malformed header block "
>> - "in dumpfile stream"));
>> + return svn_error_createf (SVN_ERR_STREAM_MALFORMED_DATA, NULL,
>> + _("Dump stream contains a malformed "
>> + "header (with no colon) ':' "
>> + "after '%.20s'"),
>> + header_str->data);
>> i++;
> [...]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jan 17 06:51:51 2006

This is an archived mail posted to the Subversion Dev mailing list.