Re: [PATCH] issue 1780: Keyword values with dollar signs cause badness.

Lieven Govaerts wrote:
> Can you agree with this change in algorithm? I don't see any problems in
> the algorithm itself, but there may be some work on the implementation.
> Performance impact is very low, due to the max. keyword length of 255 chars.

At a cursory glance, it seems like the change would work, but one thing you may
not be aware of was that SVN_KEYWORD_MAX_LEN #define may change. The reason is
that it is surprisingly easy to get a path longer than 255 characters in big
projects (like GCC, to use a real life example). I don't know if the #define is
going to be eliminated entirely or just increase by a couple powers of two.
Some testing is going to have to take place as to whether this extra looping
will have any performance issues.

In any case, some test cases and a good log message (see HACKING) are essential
to get a thorough review...

John

-- 
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org