[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] issue 1780: Keyword values with dollar signs cause badness.

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-01-10 00:21:33 CET


attached is a patch that solves issue 1780. This issue reports problems
when filenames containing '$' chars are used with keyword expansion.

The original algorithm for finding expanded keywords is changed a bit, the
result is this:

 1. - check for a '$' sign
    - if one is found, get a list of characters up to the next '$'
 2. try to translate the resulting string as a keyword
 3a. if that succeeds, go to the boring state
 3b - if translation does not succeed, make a note of the location of
       the ending '$' sign, but continue looking for the next ending '$'
     - if a next '$' is found, go back to step 2.
 4. If the string is getting larger than 255 chars or EOL is encounterd,
    stop finding the ending '$', but instead continue with the '$' on
    our stored location.
Can you agree with this change in algorithm? I don't see any problems in
the algorithm itself, but there may be some work on the implementation.
Performance impact is very low, due to the max. keyword length of 255 chars.

As soon as I get the unit tests running I'll try to provide one which tests
some common ( and less common ) scenarios.

All input is welcome.



No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.1.371 / Virus Database: 267.14.15/223 - Release Date: 6/01/2006

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Jan 10 01:07:08 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.